Apply ChromeOS cert-selection review feedback from #513#514
Merged
Conversation
Address Herman's review on #513: - Use the Devices intermediate CA: on ChromeOS, certs come from the Devices authority, not Accounts. - Wrap the team slug placeholder in parentheses to match the actual generated CA common name (e.g., `Smallstep (acme) Devices Intermediate CA`). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
J-Hunter-Hawke
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Applies Herman's review suggestions on #513 that landed after the PR was merged.
AutoSelectCertificateForUrlsJSON and the Wi-Fi Issuer pattern field now readsSmallstep ([Team Slug]) Devices Intermediate CA.Smallstep (acme) Devices Intermediate CA. Updated the placeholder to match.🤖 Generated with Claude Code